Update meson build requirement #952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, we have a build type warning due to listing a requirement for meson build version that doesn't implement features we use in our build file. The minimum meson build version required is actually 0.50.0, so this PR updates our meson.build file to depend on 0.50.0.
|
Fixes #917 |
|
We still need directions on how to build with Meson. All the cmake support is user-provided, not official. We actually use meson in TravisCI. I'll add a PR for Meson directions, plus Meson updates ... |
|
Hmmm. I don't actually see a merge commit for the README changes. Well, that's what I meant to comment on... |
|
Oh, I see. That comment was moved to CONTRIBUTING.md. Ok. I just updated Meson in my Homebrew, which took some time. Apparently we no longer support older Meson at all, which is fine... |
|
I was getting this: So I did this: -python = import('python3').find_python()
+python = find_program('python3', 'python')But I no longer see that deprecation warning either way. Strange. It does seem to be deprecated:
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we have a build type warning due to listing a requirement for
meson build version that doesn't implement features we use in our build
file. The minimum meson build version required is actually 0.50.0, so
this PR updates our meson.build file to depend on 0.50.0.